feat(iOS): Route details UI implementation #1194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to getting route details closer to spec, this also adds a HaloScrollView which displays a halo separator at the top of the scroll area when the contents are scrolled down, and this was added in most of the places where it makes sense (I didn't add it to the route picker since that's actively being worked on).
boringcactus
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: Prep for Favorites | UI Polish
In addition to getting route details closer to spec, this also adds a HaloScrollView which displays a halo separator at the top of the scroll area when the contents are scrolled down, and this was added in most of the places where it makes sense (I didn't add it to the route picker since that's actively being worked on).
I also removed the nearby transit "Select location" loading spinner and card, since it's not in the spec, was broken at small detent, was inconsistent with Android (and favorites), and resulted in multiple loading states flickering when moving the map.
iOS
- [ ] If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?- [ ] Add temporary machine translations, marked "Needs Review"Stale string was removed
Testing
N/A