fix: Reset scroll position when search results change #1240
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: | Favorites | Address UI QA - Search
What is this PR for?
This PR resets the scroll position for route search results when the results change.
I looked into addressing the AC "don't drop the background when keyboard opens" for a bit, but didn't find a suitable workaround. It looks like this is the default behavior of a
TextFieldin a sheet to accommodate the keyboard height. It is not respecting our system-defined max detent of the sheet which is surprising, and also makes it seems not worth too much effort to try and resolve.iOS
android
withContext(Dispatchers.Default)where possible (ideally in shared code)Testing
What testing have you done?