Skip to content

Conversation

@KaylaBrady
Copy link
Collaborator

Summary

Ticket:  | Favorites | Address UI QA - Search

What is this PR for?
This PR resets the scroll position for route search results when the results change.

I looked into addressing the AC "don't drop the background when keyboard opens" for a bit, but didn't find a suitable workaround. It looks like this is the default behavior of a TextField in a sheet to accommodate the keyboard height. It is not respecting our system-defined max detent of the sheet which is surprising, and also makes it seems not worth too much effort to try and resolve.

iOS

  • If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?
    • Add temporary machine translations, marked "Needs Review"

android

  • All user-facing strings added to strings resource in alphabetical order
  • Expensive calculations are run in withContext(Dispatchers.Default) where possible (ideally in shared code)

Testing

What testing have you done?

  • Ran locally, searched & scrolled repeatedly to ensure scroll position reset

@KaylaBrady KaylaBrady requested a review from a team as a code owner August 12, 2025 19:29
@KaylaBrady KaylaBrady requested a review from EmmaSimon August 12, 2025 19:29
@KaylaBrady KaylaBrady enabled auto-merge August 12, 2025 19:37
@KaylaBrady KaylaBrady added this pull request to the merge queue Aug 12, 2025
Merged via the queue into main with commit ef60732 Aug 12, 2025
11 checks passed
@KaylaBrady KaylaBrady deleted the kb-search-qa branch August 12, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants