fix(ios.NearbyTransitViewTest): More robust flakiness fix #1291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaylaBrady
commented
Sep 3, 2025
|
|
||
| sut.inspection.inspect(after: 0.5) { view in | ||
| XCTAssertNotNil(try view.view(NearbyTransitView.self) | ||
| .find(text: "Error loading data")) |
Collaborator
Author
There was a problem hiding this comment.
This test was passing no matter what text was passed here. As it turns out, the error banner isn't actually a child of NearbyTransitView, so removed this test and added coverage to NearbyTransitPage & ErrorBanner tests.
boringcactus
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: CI | ios flaky tests again
What is this PR for?
Fuller fix that I considered but didn't do in #1275.
This PR does a few things to improve the stability and readability of these tests
iOS
- [ ] If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?- [ ] Add temporary machine translations, marked "Needs Review"Testing
What testing have you done?