feat(iOS): Add global data loading modifier #1293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaylaBrady
reviewed
Sep 4, 2025
| self.stopDetailsVM = stopDetailsVM | ||
|
|
||
| leafFormat = leaf.format(now: now, globalData: stopDetailsVM.global) | ||
| leafFormat = leaf.format(now: now, globalData: nil) |
Collaborator
There was a problem hiding this comment.
question(non-blocking): Is this init of leafFormat needed? As long as there are onChange calls to set it when now or global changes, then I think this isn't needed
Contributor
Author
There was a problem hiding this comment.
Unfortunately it is, because it's not nullable and won't compile if it isn't initialized in the constructor. We could probably make it nullable, but that seemed more difficult.
Split out extensions and modifiers into separate directories.
c76e5aa to
c2ec305
Compare
c2ec305 to
afcdf9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: Prep for Move StopDetailsViewModel to shared code
Now that the global data will no longer be included in the stop details VM, we need a new way to get it in the stop/trip details views that use it. This introduces a
.globalmodifier which takes aGlobalResponsebinding and handles loading and updating global data. This gets rid of a bunch of repeated code for doing this which was scattered across a bunch of views.I'm also planning to do the same thing for favorites data, since that's also in the iOS stop details VM, and follows a similarly repetitive pattern to the global data (except in fewer places).
iOS
- [ ] If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?- [ ] Add temporary machine translations, marked "Needs Review"Testing
Updated existing tests to pass, except for a skipped StopDetailsVM test that was being difficult which will be wiped out in the follow up PR anyway.