feat(iOS): Switch over to shared stop and trip VMs #1307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmaSimon
commented
Sep 10, 2025
| .onChange(of: nearbyVM.alerts) { _ in | ||
| handleGlobalMapDataChange(now: now) | ||
| } | ||
| .onChange(of: nearbyVM.routeCardData) { _ in |
Contributor
Author
There was a problem hiding this comment.
Previously, nearbyVM.routeCardData was being set with the nearby route card data, but also, kinda inappropriately, with the stop details rcd. Since the map only cares about the stop details rcd, it was just doing this nav filtering to distinguish them. Now, this uses the molecule RouteCardDataViewModel directly, which is only updated with stop details rcd (the name isn't the best tbh). I could probably remove the stop details nav check now, not sure if it's really adding any additional safety, unless we start updating the RouteCardDataViewModel also with nearby rcd.
| } | ||
| .task { | ||
| for await model in stopDetailsVM.models { | ||
| alertSummaries = model.alertSummaries as? [String: AlertSummary?] ?? [:] |
Contributor
Author
There was a problem hiding this comment.
model.alertSummaries has a type of [String: Any], which was slightly awkward to work around.
7f3a02b to
339caf7
Compare
ec1f8db to
77fca68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: Move StopDetailsViewModel to shared code, follow up to #1273
This rips out the iOS specific
StopDetailsViewModeland replaces it with the shared stop and trip details VMs. I pulled out some VM specific handling out into modifiers, and had to rearrange a lot of the state and params in stop details, but functionality should be exactly the same.iOS
- [ ] If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?- [ ] Add temporary machine translations, marked "Needs Review"Testing
Deleted iOS VM tests that are now covered by shared tests, and a few irrelevant tests that were testing VM functionality from the views. Got all existing tests passing with the new mock VMs