feat: tap version number to show build number #1334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrandonTR
approved these changes
Sep 19, 2025
Comment on lines
+31
to
+46
| if showingBuildNumber { | ||
| Text( | ||
| "version \(version) (\(build))", | ||
| comment: "Version number and more detailed build number label on the More page" | ||
| ) | ||
| .font(Typography.footnote) | ||
| } else { | ||
| Text( | ||
| "version \(version)", | ||
| comment: "Version number label on the More page" | ||
| ) | ||
| .font(Typography.footnote) | ||
| .onTapGesture { | ||
| showingBuildNumber = true | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Kind of a nitpick but it might be worth wrapping this in a Group view and then applying the .onTapGesture modifier to that.
Group {
...
}
.font(Typography.footnote)
.onTapGesture { showingBuildNumber.toggle() }
Member
Author
There was a problem hiding this comment.
I thought about making it toggle, but I don’t think there’s any point to hiding the build number once you’ve shown it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: Display build number somewhere in app
I remember being skeptical that this was a two point ticket, and behold, it took an hour.
iOS
android
withContext(Dispatchers.Default)where possible (ideally in shared code)Testing
Added a UI test on each platform. Checked that the value is actually read from the correct place and should have the correct value in real builds.