fix: clear cached store data on logout to prevent user data leakage #6665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Module-level store refs were persisting across user sessions, causing categories and other user-specific data from one user to appear for another user after login. This was particularly problematic as it affected users across different devices. - Fix flushStore() in use-store-factory.ts to clear ref value instead of creating a new ref - Add reset functions to all store modules (category, tag, food, label, tool, cookbook, household, unit, user) - Add clearAllStores() function to reset all stores at once - Call clearAllStores() and clearNuxtData() on signOut to clear both module-level refs and Nuxt's useAsyncData cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When users log out and a different user logs in, category and other user-specific data from the previous user was persisting and displaying incorrectly. This was caused by:
useAsyncDatacache using static keys without user contextflushStore()function had a bug - it created a new ref instead of clearing the existing oneChanges:
flushStore()inuse-store-factory.tsto properly clear the ref value (store.value = []instead ofstore = ref([]))resetXxxStore()functions to all 9 store modules (category, tag, food, label, tool, cookbook, household, unit, user)clearAllStores()function instore/index.tsthat calls all reset functionssignOut()inuse-auth-backend.tsto callclearAllStores()andclearNuxtData()on logoutWhich issue(s) this PR fixes:
Fixes #5513
Testing
To test this fix: