Add ALL_SCOPES_URL variable displayed when providing a token creation link #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated an older tap based on this repository's ruby files and noticed that this variable got removed as part of the updates to github.rb. I can't say if the original variable was removed from Brew's upstream api client but without this variable the scripts crash when it fails to find a valid token.
When researching I found the original implementation that was removed as part of 98053a0 which is equivalent to the url built in Homebrew's code https://github.com/Homebrew/brew/blob/master/Library/Homebrew/utils/github/api.rb#L13-L15