[REVIEW] 445 - Fix prospector errors#446
Merged
pablodiegoss merged 10 commits intoMar 24, 2022
Merged
Conversation
Co-authored-by: Hugo Sobral <hugosobral10@gmail.com>
Co-authored-by: Sofia Patrocinio <sofiacpatrocinio@gmail.com>
Co-authored-by: Sofia Patrocinio <sofiacpatrocinio@gmail.com>
Co-authored-by: Hugo Sobral <hugosobral10@gmail.com>
Co-authored-by: Hugo Sobral <hugosobral10@gmail.com>
Co-authored-by: Sofia Patrocinio <sofiacpatrocinio@gmail.com>
Co-authored-by: Sofia Patrocinio <sofiacpatrocinio@gmail.com>
Co-authored-by: Sofia Patrocinio <sofiacpatrocinio@gmail.com>
pablodiegoss
left a comment
Member
There was a problem hiding this comment.
Amazing code improvements here, maybe you could add a little topic on the docs on how to use prospector to find and fix stylesheet problems or python code smells?
Co-authored-by: Sofia Patrocinio <sofiacpatrocinio@gmail.com>
Co-authored-by: Sofia Patrocinio <sofiacpatrocinio@gmail.com>
Contributor
@pablodiegoss We had just created a short md document about how to install and use prospector. |
pablodiegoss
approved these changes
Mar 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Correction of Prospector errors executed under Jandig's code. You can see the full tool log here.
Resolves (Issues)
Resolve #445
General tasks performed
Have you confirmed the application builds locally without error? See here.