-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
feat: Add Venn diagram #5932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
feat: Add Venn diagram #5932
Conversation
🦋 Changeset detectedLatest commit: d710d14 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@mermaid-js/examples
mermaid
@mermaid-js/layout-elk
@mermaid-js/layout-tidy-tree
@mermaid-js/mermaid-zenuml
@mermaid-js/parser
@mermaid-js/tiny
commit: |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #5932 +/- ##
==========================================
- Coverage 3.57% 3.56% -0.01%
==========================================
Files 473 480 +7
Lines 47475 47819 +344
Branches 734 741 +7
==========================================
+ Hits 1696 1704 +8
- Misses 45779 46115 +336
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
|
This draft has broken CI and conflicts, how can we move It forward? |
|
I am still working to add text nodes in each circle. |
|
+1 any timeline on this one? :) |
|
wen |
By forking @exoego 's PR and fixing the conflicts + broken CI. Hopefully adding the text in each node as he mentioned. |
|
It's a shame that this stalls, looks like a solid implementation of a very needed feature |
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📑 Summary
Resolves #2583
📏 Design Decisions
This PR leverages upsetjs/venn.js, which is a maintained d3 plugin for Venn/Euler diagram.
My syntax proposal is:
setdefines a circle or an intersectionset Aandset Bdefines a circle A and Bset A,Bdefines an intersection between A and Btextdefines a text node which belongs to one ofset📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Screenshot