connection: handle optional callbacks properly #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some public methods of Connection that perform network actions callbacks are optional. This commit fixes the behavior of default actions when a callback function is not passed so that (1) the system logic is always run and (2) a Connection doesn't complain about callback packets for unknown source packets.
5ad5a19 to
0f65dc4
Compare
Member
Author
|
Landed in 170e6d6. |
aqrln
added a commit
that referenced
this pull request
Feb 6, 2017
For some public methods of Connection that perform network actions callbacks are optional. This commit fixes the behavior of default actions when a callback function is not passed so that (1) the system logic is always run and (2) a Connection doesn't complain about callback packets for unknown source packets. PR-URL: #52
aqrln
added a commit
that referenced
this pull request
Feb 6, 2017
For some public methods of Connection that perform network actions callbacks are optional. This commit fixes the behavior of default actions when a callback function is not passed so that (1) the system logic is always run and (2) a Connection doesn't complain about callback packets for unknown source packets. PR-URL: #52
aqrln
added a commit
that referenced
this pull request
Apr 2, 2017
For some public methods of Connection that perform network actions callbacks are optional. This commit fixes the behavior of default actions when a callback function is not passed so that (1) the system logic is always run and (2) a Connection doesn't complain about callback packets for unknown source packets. Backport-of: #52
aqrln
added a commit
that referenced
this pull request
Apr 2, 2017
For some public methods of Connection that perform network actions callbacks are optional. This commit fixes the behavior of default actions when a callback function is not passed so that (1) the system logic is always run and (2) a Connection doesn't complain about callback packets for unknown source packets. Backport-of: #52
aqrln
added a commit
that referenced
this pull request
Apr 2, 2017
For some public methods of Connection that perform network actions callbacks are optional. This commit fixes the behavior of default actions when a callback function is not passed so that (1) the system logic is always run and (2) a Connection doesn't complain about callback packets for unknown source packets. Backport-of: #52 PR-URL: #113 Reviewed-by: Mykola Bilochub <nbelochub@gmail.com>
aqrln
added a commit
that referenced
this pull request
Apr 2, 2017
For some public methods of Connection that perform network actions callbacks are optional. This commit fixes the behavior of default actions when a callback function is not passed so that (1) the system logic is always run and (2) a Connection doesn't complain about callback packets for unknown source packets. Backport-of: #52 PR-URL: #113 Reviewed-by: Mykola Bilochub <nbelochub@gmail.com>
aqrln
added a commit
that referenced
this pull request
Apr 2, 2017
For some public methods of Connection that perform network actions callbacks are optional. This commit fixes the behavior of default actions when a callback function is not passed so that (1) the system logic is always run and (2) a Connection doesn't complain about callback packets for unknown source packets. Backport-of: #52 PR-URL: #113 Reviewed-by: Mykola Bilochub <nbelochub@gmail.com>
aqrln
added a commit
that referenced
this pull request
Apr 3, 2017
For some public methods of Connection that perform network actions callbacks are optional. This commit fixes the behavior of default actions when a callback function is not passed so that (1) the system logic is always run and (2) a Connection doesn't complain about callback packets for unknown source packets. Backport-of: #52 PR-URL: #113 Reviewed-by: Mykola Bilochub <nbelochub@gmail.com>
belochub
pushed a commit
that referenced
this pull request
Jan 22, 2018
For some public methods of Connection that perform network actions callbacks are optional. This commit fixes the behavior of default actions when a callback function is not passed so that (1) the system logic is always run and (2) a Connection doesn't complain about callback packets for unknown source packets. PR-URL: #52
belochub
pushed a commit
that referenced
this pull request
Jan 22, 2018
For some public methods of Connection that perform network actions callbacks are optional. This commit fixes the behavior of default actions when a callback function is not passed so that (1) the system logic is always run and (2) a Connection doesn't complain about callback packets for unknown source packets. PR-URL: #52
Merged
belochub
pushed a commit
to metarhia/mdsf
that referenced
this pull request
Jul 19, 2018
For some public methods of Connection that perform network actions callbacks are optional. This commit fixes the behavior of default actions when a callback function is not passed so that (1) the system logic is always run and (2) a Connection doesn't complain about callback packets for unknown source packets. PR-URL: metarhia/jstp#52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some public methods of Connection that perform network actions
callbacks are optional. This commit fixes the behavior of default
actions when a callback function is not passed so that (1) the system
logic is always run and (2) a Connection doesn't complain about
callback packets for unknown source packets.