Skip to content

lib, test: remove jsos #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nechaido wants to merge 3 commits into from
Closed

lib, test: remove jsos #170

nechaido wants to merge 3 commits into from

Conversation

@nechaido
Copy link
Member

@nechaido nechaido commented May 17, 2017

Refs: #160

@nechaido nechaido mentioned this pull request May 17, 2017
Closed
2 tasks
aqrln
aqrln approved these changes May 18, 2017
View reviewed changes
Copy link
Member

@aqrln aqrln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@aqrln
Copy link
Member

aqrln commented May 18, 2017

For the record: these commits should be squashed ;)

belochub
belochub approved these changes May 18, 2017
View reviewed changes
Copy link
Member

@belochub belochub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nechaido
Copy link
Member Author

nechaido commented May 19, 2017

@aqrln @belochub I've added some changes. please, review them

aqrln
aqrln approved these changes May 21, 2017
View reviewed changes
Copy link
Member

@aqrln aqrln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

nechaido added a commit that referenced this pull request May 22, 2017
@nechaido
lib, test: remove JSOS
02a83c3 
Also replace `serializer-factory` by `json5-serializer`.

PR-URL: #170
Fixes: #160
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
@nechaido
Copy link
Member Author

nechaido commented May 22, 2017 •
edited
Loading

Landed in 02a83c3.

@nechaido nechaido closed this May 22, 2017
@nechaido nechaido deleted the remove-jsos branch May 22, 2017 14:31
belochub pushed a commit that referenced this pull request Jan 22, 2018
@nechaido @belochub
lib, test: remove JSOS
2053f9f 
Also replace `serializer-factory` by `json5-serializer`.

PR-URL: #170
Fixes: #160
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub pushed a commit that referenced this pull request Jan 22, 2018
@nechaido @belochub
lib, test: remove JSOS
d0ed5c6 
Also replace `serializer-factory` by `json5-serializer`.

PR-URL: #170
Fixes: #160
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
@belochub belochub mentioned this pull request Jan 22, 2018
Merged
belochub pushed a commit to metarhia/mdsf that referenced this pull request Jul 19, 2018
@nechaido
lib, test: remove JSOS
9853396 
Also replace `serializer-factory` by `json5-serializer`.

PR-URL: metarhia/jstp#170
Fixes: metarhia/jstp#160
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub pushed a commit to metarhia/mdsf that referenced this pull request Jul 19, 2018
@nechaido
lib, test: remove JSOS
5c15dc7 
Also replace `serializer-factory` by `json5-serializer`.

PR-URL: metarhia/jstp#170
Fixes: metarhia/jstp#160
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub pushed a commit to metarhia/mdsf that referenced this pull request Jul 21, 2018
@nechaido @belochub
lib, test: remove JSOS
a182145 
Also replace `serializer-factory` by `json5-serializer`.

PR-URL: metarhia/jstp#170
Fixes: metarhia/jstp#160
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@belochub belochub belochub approved these changes

@aqrln aqrln aqrln approved these changes

Assignees

No one assigned

Labels

lib test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nechaido @aqrln @belochub