Skip to content

tcp: fix TLS server creation #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aqrln wants to merge 1 commit into from
Closed

tcp: fix TLS server creation #197

aqrln wants to merge 1 commit into from

Conversation

@aqrln
Copy link
Member

@aqrln aqrln commented May 31, 2017

TLS functionality was effectively broken in 11d7795. This commit restores it and adds a regression test.

@aqrln
tcp: fix TLS server creation
1498981 
TLS functionality was effectively broken in
11d7795. This commit restores it and
adds a regression test.
belochub
belochub approved these changes May 31, 2017
View reviewed changes
Copy link
Member

@belochub belochub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lundibundi
lundibundi approved these changes May 31, 2017
View reviewed changes
Copy link
Member

@lundibundi lundibundi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aqrln added a commit that referenced this pull request Jun 1, 2017
@aqrln
tcp: fix TLS server creation
4edbc20 
TLS functionality was effectively broken in
11d7795. This commit restores it and
adds a regression test.

PR-URL: #197
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
@aqrln
Copy link
Member Author

aqrln commented Jun 1, 2017

Landed in 4edbc20.

@aqrln aqrln closed this Jun 1, 2017
@aqrln aqrln deleted the tls-covfefe branch June 1, 2017 10:31
@belochub belochub mentioned this pull request Sep 19, 2017
Closed
belochub pushed a commit that referenced this pull request Jan 22, 2018
@aqrln @belochub
tcp: fix TLS server creation
15cf815 
TLS functionality was effectively broken in
11d7795. This commit restores it and
adds a regression test.

PR-URL: #197
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
belochub pushed a commit that referenced this pull request Jan 22, 2018
@aqrln @belochub
tcp: fix TLS server creation
541ae83 
TLS functionality was effectively broken in
11d7795. This commit restores it and
adds a regression test.

PR-URL: #197
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
@belochub belochub mentioned this pull request Jan 22, 2018
Merged
belochub pushed a commit to metarhia/mdsf that referenced this pull request Jul 19, 2018
@aqrln
tcp: fix TLS server creation
37fd92b 
TLS functionality was effectively broken in
11d7795. This commit restores it and
adds a regression test.

PR-URL: metarhia/jstp#197
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
belochub pushed a commit to metarhia/mdsf that referenced this pull request Jul 19, 2018
@aqrln
tcp: fix TLS server creation
3b93d29 
TLS functionality was effectively broken in
11d7795. This commit restores it and
adds a regression test.

PR-URL: metarhia/jstp#197
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@belochub belochub belochub approved these changes

@lundibundi lundibundi lundibundi approved these changes

Assignees

No one assigned

Labels

bug tcp

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aqrln @belochub @lundibundi