cli: fix exception on unestablished connection #210
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you made connect but connection was not established yet cli would fail on call and event commands with exception. Add error message Connection in progress.
aqrln
approved these changes
Jun 5, 2017
belochub
reviewed
Jun 6, 2017
| } | ||
|
|
||
| call(interfaceName, methodName, args, callback) { | ||
| if (!this.cli.client) return callback(new Error('Not connected')); |
Member
There was a problem hiding this comment.
@lundibundi
What do you say about removing redundant indentation by leaving line 91 as it was, and just adding this:
if (!this.cli.connection) return callback(new Error('Connection in progress'));
belochub
pushed a commit
that referenced
this pull request
Jun 8, 2017
When you made connect but connection was not established yet cli would fail on call and event commands with exception. Add error message Connection in progress. PR-URL: #210 Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Member
|
Landed in 6cb62a0. |
belochub
pushed a commit
that referenced
this pull request
Jan 22, 2018
When you made connect but connection was not established yet cli would fail on call and event commands with exception. Add error message Connection in progress. PR-URL: #210 Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub
pushed a commit
that referenced
this pull request
Jan 22, 2018
When you made connect but connection was not established yet cli would fail on call and event commands with exception. Add error message Connection in progress. PR-URL: #210 Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you made connect but connection was not established yet cli would fail on call and event commands with exception.
Not sure about message in new error so feel free to suggest another one.