Skip to content

deps: add missing uuid dependency #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aqrln wants to merge 1 commit into from
Closed

deps: add missing uuid dependency #280

aqrln wants to merge 1 commit into from

Conversation

@aqrln
Copy link
Member

@aqrln aqrln commented Jul 28, 2017

Add a missing dependency to package.json.

The package was located in the tree as a deduplicated transitive
dependency, so it went unnoticed until the tree changed its shape in
#277

@aqrln
deps: add missing uuid dependency
6e03dc3 
Add a missing dependency to package.json.

The package was located in the tree as a deduplicated transitive
dependency, so it went unnoticed until the tree changed its shape in
#277
nechaido
nechaido approved these changes Jul 28, 2017
View reviewed changes
Copy link
Member

@nechaido nechaido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aqrln
Copy link
Member Author

aqrln commented Jul 28, 2017

I am going to fast-track this because current version in master doesn't even work without devDependencies.

aqrln added a commit that referenced this pull request Jul 28, 2017
@aqrln
deps: add missing uuid dependency
5b398d0 
Add a missing dependency to package.json.

The package was located in the tree as a deduplicated transitive
dependency, so it went unnoticed until the tree changed its shape in
#277

PR-URL: #280
Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
@aqrln
Copy link
Member Author

aqrln commented Jul 28, 2017

Landed in 5b398d0.

@aqrln aqrln closed this Jul 28, 2017
@aqrln aqrln deleted the fix/add-missing-dependency branch July 28, 2017 12:15
belochub pushed a commit that referenced this pull request Jan 22, 2018
@aqrln @belochub
deps: add missing uuid dependency
44fae25 
Add a missing dependency to package.json.

The package was located in the tree as a deduplicated transitive
dependency, so it went unnoticed until the tree changed its shape in
#277

PR-URL: #280
Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub pushed a commit that referenced this pull request Jan 22, 2018
@aqrln @belochub
deps: add missing uuid dependency
ea277e9 
Add a missing dependency to package.json.

The package was located in the tree as a deduplicated transitive
dependency, so it went unnoticed until the tree changed its shape in
#277

PR-URL: #280
Reviewed-By: Dmytro Nechai <nechaido@gmail.com>
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
@belochub belochub mentioned this pull request Jan 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@belochub belochub belochub approved these changes

@nechaido nechaido nechaido approved these changes

Assignees

No one assigned

Labels

bug deps

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aqrln @belochub @nechaido