Add TypeScript type tests for check, random, email, fetch and tracker packages #13951

gauravarora · 2025-10-02T17:23:56Z

Summary

Addresses issue Type tests for Meteor packages #13676 by adding TypeScript type tests to verify type definitions work correctly
Establishes a pattern for adding type tests to other packages with .d.ts files
Added comprehensive type tests for 5 packages: check, random, tracker, fetch, and email

Changes

check: Added type tests for Match patterns (Maybe, Optional, OneOf, ObjectIncluding, Where, Integer, Any) and check() assertions
random: Added type tests for all Random methods (id, secret, fraction, hexString, choice)
tracker: Added type tests for Tracker.autorun, Computation interface, Dependency class, and reactive utilities
fetch: Added type tests for fetch(), Headers, Request, and Response APIs
email: Added type tests for Email.sendAsync(), hookSend(), customTransport(), and MailComposer

Pattern for other packages

Each package now follows this pattern:

Add 'typescript' to Package.onTest() dependencies
Create a *_test.ts file with type tests using api.mainModule()
Import APIs and verify type signatures, return types, and type narrowing

Fixes #13676

Addresses issue meteor#13676 by adding TypeScript type tests to verify type definitions work correctly. This establishes a pattern for adding type tests to other packages with .d.ts files. Changes: - check: Added comprehensive type tests for Match patterns and check() assertions - random: Added type tests for all Random methods (id, secret, fraction, hexString, choice) - tracker: Added type tests for Tracker.autorun, Computation, Dependency, and reactive utilities

netlify · 2025-10-02T17:24:02Z

✅ Deploy Preview for v3-meteor-api-docs canceled.

Name	Link
🔨 Latest commit	`aa49cd7`
🔍 Latest deploy log	https://app.netlify.com/projects/v3-meteor-api-docs/deploys/68e7769a05fec800087ae2d0

netlify · 2025-10-02T17:24:02Z

✅ Deploy Preview for v3-migration-docs canceled.

Name	Link
🔨 Latest commit	`aa49cd7`
🔍 Latest deploy log	https://app.netlify.com/projects/v3-migration-docs/deploys/68e7769a3974b80008735a40

CLAassistant · 2025-10-02T17:24:03Z

All committers have signed the CLA.

- fetch: Added type tests for fetch(), Headers, Request, and Response APIs - email: Added type tests for Email.sendAsync(), hookSend(), customTransport(), and MailComposer

italojs · 2025-10-20T08:33:20Z

packages/check/match_test.ts

+import { Tinytest } from "meteor/tinytest";
+import { check, Match } from "meteor/check";
+
+Tinytest.add("Check - TypeScript types - basic check function", (test) => {


would be better to have a test for "general types" so test string, number, obj...

italojs · 2025-10-20T08:39:02Z

packages/check/match_test.ts

+  test.equal(upper, "HELLO");
+});
+
+Tinytest.add("Check - TypeScript types - Match.test with primitives", (test) => {


Check lib isnt a typescript feature, all this file have TypeScript types in the test descriptions, bu none of them is testing typescript related things, Number and String is js native

italojs · 2025-10-20T08:40:00Z

packages/check/package.js

+  api.use(['check', 'tinytest', 'ejson', 'ecmascript', 'typescript'], ['client', 'server']);

  api.addFiles('match_test.js', ['client', 'server']);
+  api.mainModule('match_test.ts');


the file is .ts but isnt using ts statement 🤷🏻‍♂️
vote to remove it

italojs · 2025-10-20T08:41:58Z

packages/email/email_tests.ts

+
+Tinytest.add("Email - TypeScript types - sendAsync options", (test) => {
+  // Type check that sendAsync accepts proper options
+  const options = {


is missing the type EmailOptions

italojs · 2025-10-20T08:43:16Z

packages/email/email_tests.ts

+});
+
+Tinytest.add("Email - TypeScript types - hookSend", (test) => {
+  Email.hookSend((options) => {


missing the type EmailOptions into options Email.hookSend((options: EmailOptions) => {

italojs · 2025-10-20T08:53:29Z

packages/fetch/tests/main.ts

+import { Tinytest } from "meteor/tinytest";
+import { fetch, Headers, Request, Response } from "meteor/fetch";
+
+Tinytest.addAsync("Fetch - TypeScript types - fetch function", async (test, done) => {


here we are testing node's fetch, not a method stuff, remove all tests like this, please
featch already have your own tests

italojs · 2025-10-20T08:56:31Z

packages/tracker/tracker_tests.ts

+});
+
+Tinytest.add("Tracker - TypeScript types - Computation properties", (test) => {
+  const computation = Tracker.autorun((c) => {


missing the type ...: Tracker.Computation =...

italojs · 2025-10-20T08:57:55Z

packages/tracker/tracker_tests.ts

+    const stopped: boolean = c.stopped;
+    const promise: Promise<unknown> = c.firstRunPromise;
+
+    test.equal(typeof firstRun, "boolean");


it's typescript, Boolean doent work here?

italojs · 2025-10-20T08:58:31Z

packages/email/email_tests.ts

+
+  // This ensures the type signature is correct
+  const sendPromise: Promise<void> = Email.sendAsync(options);
+  test.equal(typeof sendPromise.then, "function");


it's typescript, instanceof Promise doesnt work here?

italojs · 2025-10-20T08:59:40Z

packages/tracker/tracker_tests.ts

+  test.equal(computation.invalidated, true);
+
+  computation.onInvalidate((c: Tracker.Computation) => {
+    test.equal(typeof c, "object");


should be typeof c, Tracker.Computation

Add TypeScript type tests for fetch and email packages

5738558

- fetch: Added type tests for fetch(), Headers, Request, and Response APIs - email: Added type tests for Email.sendAsync(), hookSend(), customTransport(), and MailComposer

github-actions bot added Project:Utilities:Email Project:Utilities:HTTP labels Oct 2, 2025

gauravarora changed the title ~~Add TypeScript type tests for check, random, and tracker packages~~ Add TypeScript type tests for check, random, email, fetch and tracker packages Oct 2, 2025

StorytellerCZ added Project:JS Environment:Typescript Project:TypeScript-conversion labels Oct 2, 2025

italojs and others added 2 commits October 6, 2025 11:04

Merge branch 'devel' into add-typescript-type-tests

203cccb

Merge branch 'devel' into add-typescript-type-tests

aa49cd7

italojs requested changes Oct 20, 2025

View reviewed changes

Add TypeScript type tests for check, random, email, fetch and tracker packages #13951

Are you sure you want to change the base?

Add TypeScript type tests for check, random, email, fetch and tracker packages #13951

Uh oh!

Conversation

gauravarora commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Pattern for other packages

Uh oh!

netlify bot commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for v3-meteor-api-docs canceled.

Uh oh!

netlify bot commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for v3-migration-docs canceled.

Uh oh!

CLAassistant commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

italojs Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gauravarora commented Oct 2, 2025 •

edited

Loading

netlify bot commented Oct 2, 2025 •

edited

Loading

netlify bot commented Oct 2, 2025 •

edited

Loading

CLAassistant commented Oct 2, 2025 •

edited

Loading

italojs Oct 20, 2025 •

edited

Loading