feat(cli): wip #922
Draft
feat(cli): wip #922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughrawlinson
commented
Jul 19, 2021
| @@ -0,0 +1,50 @@ | |||
| import {SampleBufferStream} from "../../src/cli/SampleBufferStream"; | |||
|
|
|||
| describe(SampleBufferStream, () => { | |||
Member
Author
There was a problem hiding this comment.
These tests were generated with GitHub Copilot, I have no idea what they do
| @@ -0,0 +1,45 @@ | |||
| import { Transform } from "stream"; | |||
|
|
|||
| export class SampleBufferStream< | |||
Member
Author
There was a problem hiding this comment.
Extremely don't use this - it will fail when the hop size is greater than the contents of the buffer.
| return x in options; | ||
| } | ||
|
|
||
| const p = "a".slice(0); |
Member
Author
There was a problem hiding this comment.
This is code testing the function above and should be deleted.
| export function parseReceivedOptions(receivedOptions: { | ||
| [key: string]: unknown; | ||
| }): CliOptions { | ||
| switch (true) { |
Member
Author
There was a problem hiding this comment.
this rather inscrutable block has me questioning the switch(true) pattern.
| @@ -0,0 +1,16 @@ | |||
| { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.