[rubberband] Use FFTW3 when targeting iOS or WASM #37101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 2, 2024
Cheney-W
approved these changes
Mar 4, 2024
fwcd
added a commit
to fwcd/vcpkg
that referenced
this pull request
Mar 5, 2024
`sleef` currently has some issues cross-compiling (see microsoft#37091), preventing `rubberband` from building. Using FFTW as the FFT backend when targeting iOS or WASM/Emscripten therefore fixes the cross-build for `rubberband`. Since we already use FFTW on arm64 macOS, using it on iOS too should also make things a bit more consistent. - [x] Changes comply with the [maintainer guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md). - [x] SHA512s are updated for each updated download. - [x] The "supports" clause reflects platforms that may be fixed by this new version. - [x] Any fixed [CI baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt) entries are removed from that file. - [x] Any patches that are no longer applied are deleted from the port's directory. - [x] The version database is fixed by rerunning `./vcpkg x-add-version --all` and committing the result. - [x] Only one version is added to each modified port's versions file.
daschuer
added a commit
to mixxxdj/vcpkg
that referenced
this pull request
Mar 5, 2024
[rubberband] Use FFTW3 when targeting iOS or WASM (microsoft#37101)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sleefcurrently has some issues cross-compiling (see #37091), preventingrubberbandfrom building.Using FFTW as the FFT backend when targeting iOS or WASM/Emscripten therefore fixes the cross-build for
rubberband. Since we already use FFTW on arm64 macOS, using it on iOS too should also make things a bit more consistent../vcpkg x-add-version --alland committing the result.