[lunasvg] Update 2.3.8 #32510
Merged
[lunasvg] Update 2.3.8 #32510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@microsoft-github-policy-service agree |
dg0yt
reviewed
Jul 11, 2023
ports/lunasvg/fix-install.patch
Outdated
| --- a/CMakeLists.txt | ||
| +++ b/CMakeLists.txt | ||
| @@ -24,16 +24,5 @@ if(LUNASVG_BUILD_EXAMPLES) | ||
| @@ -23,16 +23,5 @@ if(LUNASVG_BUILD_EXAMPLES) |
Contributor
There was a problem hiding this comment.
If there is no other change, maybe leave the patch unchanged?
Contributor
Author
There was a problem hiding this comment.
My mistake, I thought since the CMakelist.txt has changed, the patch also needed to be updated
Member
There was a problem hiding this comment.
The patch needs to be changed if and only if the old patch doesn't apply cleanly.
ports/lunasvg/portfile.cmake
Outdated
| REPO sammycage/lunasvg | ||
| REF e612abda858b53160041381a23422cd2b4f42fbd #2.3.1 | ||
| SHA512 44f5d013d918cb5af90114a12857bdd2c204caff761516ef98b12b08d8b6215e91f6d963c281500c386f287b9d0ecd5b3d986d4c8c33423c0c34d539d744e09d | ||
| REF 87137e791c912432b93982722a8e965628950ca7 #2.3.8 |
Contributor
There was a problem hiding this comment.
Suggested change
| REF 87137e791c912432b93982722a8e965628950ca7 #2.3.8 | |
| REF "v${VERSION} |
... which will have a different SHA512.
BillyONeal
previously approved these changes
Jul 11, 2023
FrankXie05
previously approved these changes
Jul 12, 2023
FrankXie05
reviewed
Jul 12, 2023
Co-authored-by: Frank <65999885+FrankXie05@users.noreply.github.com>
FrankXie05
suggested changes
Jul 12, 2023
Contributor
|
Every change requires running the command |
FrankXie05
approved these changes
Jul 12, 2023
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.