-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Added support for Toybox to remote process picker #11175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Toybox to remote process picker #11175
Conversation
|
@microsoft-github-policy-service agree company="Software Mansion" |
This would lead to more issues for users tyring to get their command to match what We would reccomend writing a vscode input variable instead, as users can run their own vscode command and parse their own ouput to the value they want for the launch.json. https://code.visualstudio.com/docs/editor/variables-reference#_input-variables E.g. launch.json {
"configurations": [
{
"type": "cppdbg",
"request": "attach",
"name": "Run Program",
"program": "${workspaceFolder}/a,out",
"processId": "${input:pickProcess}"
}
],
"inputs": [
{
"id": "pickProcess",
"type": "command",
"command": "extension.my.cysto.testPicker"
}
]
} |
|
what about forcing such custom command to return data as CSV? Having this implemented for custom command will avoid this issue |
That sounds good, I think there also need to be an associated field indicating the format of the output. E.g. Another question is that is there a reason why ToyBox's ps deviates from the standard usage? Is there a good way to detect that the |
bd46a26 to
2053fc9
Compare
|
@WardenGnaw I've changed implementation to just support Toybox detection and proper command for getting remote process list. For some reason Toybox's |
Hello and thanks for maintaining this repo!
I've come along a problem where my remote target needed to have different arguments for
pscommand in order to retrieve remote processes list. It was using ToyBox'spsand I added option for specifying custom command for getting processes list.Current approach allows either using
pswith different arguments or even using other command, see examples:One needs to have in mind that the custom command needs to return output in the same format as currently used commands do