fix fuzzyScore boost for uppercase full match #187149
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
636b3ab to
3616e3e
Compare
facebook-github-bot
pushed a commit
to facebook/flow
that referenced
this pull request
Jul 7, 2023
Summary: Uppercase characters in a common prefix of a fuzzy match are given an undue boost. This manifests when trying to sort without boosting full matches. When searching for `F` with `boost_full_match = false`, the score for `F` is still +2 the score for `Foo` even though they should be equal. Ports microsoft/vscode#187149 to our ocaml fork Reviewed By: SamChou19815 Differential Revision: D47251873 fbshipit-source-id: 32e5102747cf3bb4c9ec613f613f546c52dbc596
facebook-github-bot
pushed a commit
to facebook/flow
that referenced
this pull request
Jul 7, 2023
Summary: Uppercase characters in a common prefix of a fuzzy match are given an undue boost. This manifests when trying to sort without boosting full matches. When searching for `F` with `boost_full_match = false`, the score for `F` is still +2 the score for `Foo` even though they should be equal. Ports microsoft/vscode#187149 to our ocaml fork Reviewed By: SamChou19815 Differential Revision: D47251873 fbshipit-source-id: 6d6bf9dc0c87bb4c25f5064b751a8ecdb6d72329
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
fuzzyScoreto not treat uppercase characters in a common prefix as gap locations.If you match
FOOagainstFOOandFOOBAR, the score againstFOOis +4 compared toFOOBAR: +2 for being a full match, and +2 because gap locations at the end of the word are only penalized -3 instead of -5. This PR fixes the latter +2. This makes the scores equal whenboostFullMatch: false.Fixes #187147