Fix inline diff icon hard to click #214554
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@alexr00 Hi, do you have time to review this? It's been half a month, pinging just in case you missed it |
Member
|
Thanks for the ping, I wasn't aware of this PR! |
alexr00
reviewed
Jun 20, 2024
| lineOutput += `<div class="cldr ${decoration.className}"${decoration.tooltip !== null ? ` title="${decoration.tooltip}"` : ''}></div>`; | ||
| } | ||
| output[lineIndex] = lineOutput; | ||
| output[lineIndex] = `<div class="line-decor-container" style="left:${left}px;width:${width}px;">${lineOutput}</div>`; |
Member
There was a problem hiding this comment.
@alexdima I'm a little concerned about this as it adds another layer of div in the line decorations. It looks fine though.
Contributor
Author
Member
|
@Legend-Master you are correct, thanks! |
Member
Contributor
|
@alexr00 Looks good to me! |
Contributor
Author
|
@alexdima Hi, it's been more than 2 months, do you have time to take a look? |
|
Is this still relevant? |
Contributor
Author
It's definitely a yes to me |
Member
|
@aeschli Please review and merge if the changes look good to you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #214541
Fix #197883
This is how it works after the change
video1.mp4