drag-and-drop: ensure correct drag image for panel tabs (Fixes #239048) #243853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes microsoft#239048 where dragging the title of a tab in the lower panel would display incorrect text in the drag image. Modified the drag-and-drop handler to prioritise using the .action-label element as the drag image when available; otherwise, it falls back to using the entire element. Adds tests to verify that the drag image uses the .action-label when present and defaults to the container element when the .action-label is absent.
Author
|
@microsoft-github-policy-service agree |
Author
|
Hi @benibenj, just following up on this PR. Let me know if you have any feedback or if anything is needed from my side. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #239048 where dragging the title of a tab in the lower panel would display incorrect text in the drag image. This issue was caused by the drag operation defaulting to the entire container, which could include unexpected text from adjacent UI elements.
Modified the drag-and-drop handler to prioritise using the .action-label element as the drag image when available, ensuring a more accurate and visually consistent drag representation. If no .action-label is found, the fallback is the entire container to maintain expected behaviour.
Added tests to verify that: