Chat - implement session picker in the chat panel title #281051

lszomoru · 2025-12-03T20:33:48Z

Anchored quick pick
Adopt anchored quick pick in the session picker

Copilot

Pull request overview

This PR implements a session picker in the chat panel title that allows users to switch between agent sessions. The implementation includes refactoring layout logic from contextview.ts into a new reusable layout.ts utility module, adding anchored quick pick support, and creating a custom action view item to display the session title as a clickable picker.

Key Changes:

Extracted layout positioning logic into a new reusable module (src/vs/base/common/layout.ts) with 1D and 2D layout functions
Added anchor support to quick input service for positioning relative to DOM elements
Implemented a session picker action in the chat view title toolbar that opens an anchored quick pick

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
`src/vs/base/common/layout.ts`	New utility module containing extracted layout positioning algorithms for anchoring UI elements
`src/vs/base/browser/ui/contextview/contextview.ts`	Refactored to use the new layout utility and extracted `getAnchorRect` helper function
`src/vs/base/browser/ui/menu/menu.ts`	Updated to use the new layout API that returns an object with `.position` property
`src/vs/base/test/common/layout.test.ts`	Updated tests to verify the `.position` property from the new `ILayoutResult` return type
`src/vs/platform/quickinput/common/quickInput.ts`	Added `anchor` property to `IPickOptions` and `IQuickInput` interfaces for anchored positioning
`src/vs/platform/quickinput/browser/quickInputController.ts`	Implemented anchored positioning logic using the new layout utility when `anchor` is specified
`src/vs/workbench/contrib/chat/browser/chatViewTitleControl.ts`	Created custom action view item for displaying session title and implemented `ChatViewTitleAgentPicker` class
`src/vs/workbench/contrib/chat/browser/chatViewPane.ts`	Added `pickSession()` method to launch the session picker
`src/vs/workbench/contrib/chat/browser/actions/chatNewActions.ts`	Registered new action for picking agent sessions in the chat view title toolbar
`src/vs/workbench/contrib/chat/browser/actions/chatActions.ts`	Exported new action ID constant `ACTION_ID_PICK_AGENT_SESSION`

src/vs/platform/quickinput/browser/quickInputController.ts

src/vs/workbench/contrib/chat/browser/chatViewTitleControl.ts

src/vs/base/common/layout.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

src/vs/platform/quickinput/common/quickInput.ts

src/vs/workbench/contrib/chat/browser/actions/chatNewActions.ts

src/vs/workbench/contrib/chat/browser/chatViewPane.ts

src/vs/workbench/contrib/chat/browser/chatViewTitleControl.ts

bpasero · 2025-12-10T14:57:48Z

@lszomoru good start! I brought main back in and left some comments. On a high level I also wonder if the sessions picker could actually look a bit more like the actual session cards (i.e. 2 lines, with title and description) so that the representation is not so different?

I think the changes to quick pick need review from @TylerLeonhardt

lszomoru

@bpasero, thank you very much for looking at the changes. I have pushed some changes to address your feedback. One issue that is still present is that even though I have isolated the picker, the title control still needs to expose the anchor element which is then used by the picker so that the picker can be anchored.

TylerLeonhardt · 2025-12-11T15:17:43Z

I will review after issue grooming unless you need it sooner

bpasero

@lszomoru please see my commits, by moving the action into the title, a lot of things become easier because no need to send around the HTMLElement where to show the picker.

I am seeing some slight layout issues with the picker in the title:

it seems to increase the height of the title, making the icons jump a bit when title shows and goes
it overflows out of the container, pushing away the sidebar:

Also it does not seem to close when clicked outside:

As for opening the session, can we borrow some of the logic we have when clicking on a session in the viewer? I mean this code:

vscode/src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsPicker.ts

Lines 43 to 45 in 89a511e

    
           if (session?.session.resource) { 
        
           	this.chatWidgetService.openSession(session.session.resource, ChatViewPaneTarget); 
        
           }

and how we open here:

vscode/src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsControl.ts

Line 129 in 89a511e

    
           private async openAgentSession(e: IOpenEvent<IAgentSession | undefined>): Promise<void> {

I would also suggest to support opening in background as editor as alt open behaviour from the picker.

Are we doing something to make the picker look a bit more polished?

lszomoru · 2025-12-11T15:57:44Z

@lszomoru please see my commits, by moving the action into the title, a lot of things become easier because no need to send around the HTMLElement where to show the picker.

Hence my original implementation :)

lszomoru · 2025-12-12T09:41:55Z

@TylerLeonhardt, to make things easier to review, I have updated the PR to reduce its scope. The PR now only includes the changes to enable the anchor option for the quick input widget and the adoption of this new option for the agent sessions picker. Please let me know if you have any questions or concerns. Thanks!

TylerLeonhardt

bug.mov

There's a weird behavior that happens when you attempt to drag the quick pick from the title bar. It causes the position of the command palette to get messed up.

Steps:

open the chat panel title picker
drag the picker down (it doesn't move, expected)
with it still open, cmd+shift+p
🐛 the command palette is influenced by the location of the chat panel title quick pick

TylerLeonhardt · 2025-12-17T23:40:55Z

src/vs/platform/quickinput/common/quickInput.ts

+	/**
+	 * An optional anchor for the quick input.
+	 */
+	anchor?: HTMLElement | { x: number; y: number };


This being supported means that showing could happen first:

qp.show(); qp.anchor = foo;

we need to update the anchor when it is set.

TylerLeonhardt · 2025-12-18T00:11:06Z

Generally, there's a lot of math here which worries me, but it's needed for the feature... I didn't test:

what happens when the anchor is by the edge of the screen
how wonky does this look when the anchor is close to the bottom of the screen (I want the input on the bottom, but I know this PR doesn't do that)

but since this is scoped to just the chat panel title, those don't apply I suppose

Copilot AI review requested due to automatic review settings December 3, 2025 20:33

lszomoru self-assigned this Dec 3, 2025

lszomoru requested a review from bpasero December 3, 2025 20:33

Copilot started reviewing on behalf of lszomoru December 3, 2025 20:34 View session

Copilot finished reviewing on behalf of lszomoru December 3, 2025 20:38

Copilot AI reviewed Dec 3, 2025

View reviewed changes

joaomoreno previously approved these changes Dec 4, 2025

View reviewed changes

joaomoreno and others added 8 commits December 4, 2025 11:21

refactor layout and layout2d into base common

36086f0

support anchored quick pick

dc74884

wip: use anchored quick pick in scm

43089ff

almost there

8a6a840

undo scm history view pane

50b7d11

Chat - implement session picker in the chat panel title

1e4b632

Apply suggestions from code review

dd4e037

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Port changes again, and clean things up

fc0f7f4

lszomoru dismissed joaomoreno’s stale review via fc0f7f4 December 4, 2025 10:41

lszomoru force-pushed the lszomoru/session-picker branch from 407d2de to fc0f7f4 Compare December 4, 2025 10:41

bpasero added this to the December / January 2026 milestone Dec 10, 2025

Merge branch 'main' into lszomoru/session-picker

1854ef8

bpasero requested changes Dec 10, 2025

View reviewed changes

bpasero requested a review from TylerLeonhardt December 10, 2025 14:57

Pull request feedback

dc483d3

lszomoru commented Dec 11, 2025

View reviewed changes

lszomoru requested a review from bpasero December 11, 2025 15:01

bpasero added 4 commits December 11, 2025 16:17

Merge branch 'main' into lszomoru/session-picker

3d85e0b

missing changes

8efd0ba

cleanup

ec22f32

fix bad merge

a8ba87a

bpasero added 3 commits December 11, 2025 16:42

reduce complexity

a48e216

polish

f37681c

update title

89a511e

bpasero requested changes Dec 11, 2025

View reviewed changes

lszomoru added 2 commits December 12, 2025 10:28

Merge branch 'main' into lszomoru/session-picker

45f7e05

Adopt the anchor

51b26b6

lszomoru requested a review from bpasero December 12, 2025 09:37

Fix compilation error

2d155dc

lszomoru marked this pull request as ready for review December 12, 2025 09:42

lszomoru and others added 2 commits December 16, 2025 09:35

Fix monaco editor check

6b96e4b

Merge branch 'main' into lszomoru/session-picker

143a0c3

TylerLeonhardt requested changes Dec 17, 2025

View reviewed changes

TylerLeonhardt reviewed Dec 17, 2025

View reviewed changes

bpasero removed their request for review December 18, 2025 06:17

	if (session?.session.resource) {
	this.chatWidgetService.openSession(session.session.resource, ChatViewPaneTarget);
	}

Chat - implement session picker in the chat panel title #281051

Are you sure you want to change the base?

Chat - implement session picker in the chat panel title #281051

Conversation

lszomoru commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bpasero commented Dec 10, 2025

Uh oh!

lszomoru left a comment

Choose a reason for hiding this comment

Uh oh!

TylerLeonhardt commented Dec 11, 2025

Uh oh!

bpasero left a comment

Choose a reason for hiding this comment

Uh oh!

lszomoru commented Dec 11, 2025

Uh oh!

lszomoru commented Dec 12, 2025

Uh oh!

TylerLeonhardt left a comment

Choose a reason for hiding this comment

Uh oh!

TylerLeonhardt Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

TylerLeonhardt commented Dec 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

lszomoru commented Dec 3, 2025 •

edited

Loading