agent sessions - update confirmation color and UX #283585
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the visual representation of agent sessions that need user input by changing both the icon and color scheme. The change improves the UX by making the "needs input" state less alarming (moving from a warning icon to a comment icon) and more consistent with the interactive/actionable nature of these sessions.
Key Changes
- Icon change: Replaced warning icon (
Codicon.warning) with comment icon (Codicon.comment) forChatSessionStatus.NeedsInput - Color update: Changed from warning-colored icon to link-colored icon (using
textLink-foreground) to better convey interactivity - Color standardization: Updated error icon color from
editorError-foregroundtoerrorForeground
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsViewer.ts |
Changes the icon returned for NeedsInput status from warning to comment |
src/vs/workbench/contrib/chat/browser/agentSessions/media/agentsessionsviewer.css |
Updates CSS to style the new comment icon with link color and changes error icon to use errorForeground variable |
|
|
||
| &.codicon.codicon-error { | ||
| color: var(--vscode-editorError-foreground); | ||
| color: var(--vscode-errorForeground); |
There was a problem hiding this comment.
The change from editorError-foreground to errorForeground creates an inconsistency within the chat feature. Other parts of the chat UI still use editorError-foreground (see line 2248 in src/vs/workbench/contrib/chat/browser/media/chat.css). While both colors exist and are valid, the codebase should use consistent color variables for the same semantic meaning. Consider either keeping editorError-foreground here or updating the other usage in chat.css to errorForeground for consistency.
| color: var(--vscode-errorForeground); | |
| color: var(--vscode-editorError-foreground); |
No description provided.