check the end part of legacyToolReferenceFullNames when evaluating EligibleForAutoApproval
#283887
+174
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrivMS
approved these changes
Dec 16, 2025
pwang347
approved these changes
Dec 16, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the EligibleForAutoApproval evaluation logic to support backward compatibility for namespaced legacy tool names. When a tool was previously namespaced (e.g., gitTools/gitCommit) and is now renamed or moved, users can configure eligibility using either the full legacy name or just the last segment (e.g., gitCommit).
Key Changes
- Added logic to extract and check the last segment of namespaced legacy tool names when evaluating eligibility for auto-approval
- Replaced hardcoded string literals with the
ChatConfiguration.EligibleForAutoApprovalconstant in tests - Added comprehensive test coverage for namespaced legacy tool name scenarios (both eligible and ineligible cases)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/browser/languageModelToolsService.ts |
Enhanced isToolEligibleForAutoApproval to check both full legacy names and their trimmed segments (after the last /) when evaluating eligibility configuration |
src/vs/workbench/contrib/chat/test/browser/languageModelToolsService.test.ts |
Replaced hardcoded configuration strings with constant; added four new tests covering namespaced legacy tool name scenarios for both eligible and ineligible cases |
src/vs/workbench/contrib/chat/test/browser/languageModelToolsService.test.ts
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/test/browser/languageModelToolsService.test.ts
Show resolved
Hide resolved
joshspicer
added a commit
that referenced
this pull request
Dec 16, 2025
…`EligibleForAutoApproval` (#283887) * check the end part of legacyToolReferenceFullNames when evaluating EligibleForAutoApproval * improve * tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref https://github.com/microsoft/vscode-internalbacklog/issues/6465