Fix ArgvToCommandLine SFINAE
#536
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TL;DR is that you can't SFINAE in type definitions, so we hit a hard compilation error during overload resolution when
ArgvToCommandLineis called with just an argc+argv pair with the intent of using the default flags. My original primary use-case used avector<basic_string>and the tests only called the argc+argv overload with flags explicitly set, so this never got caught.