Fixes for VM reconnect #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR addresses three bugs related to VM reconnection and disk hydration in the Hyper-V virtualization layer. The key changes improve path comparison for VHD detection and add support for reading the disk type (dynamic vs. fixed) from WMI disk settings.
- Improved path comparison to handle case-insensitive and cross-platform path matching
- Added ability to detect whether a disk is dynamic or fixed from WMI settings
- Updated tests to verify the new dynamic flag functionality
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| pkg/virtualization/core/virtualsystem/virtualmachine.go | Enhanced path comparison in GetVirtualHardDiskByPath to use case-insensitive matching with filepath.Clean and strings.ToLower |
| pkg/virtualization/core/storage/disk/virtualharddisksettingdata.go | Added VirtualHardDiskTypeSetting enum and logic to parse disk Type field from XML to determine if disk is dynamic |
| pkg/virtualization/core/storage/service/ImageManagementService.go | Updated GetVirtualHardDiskConfig signature to return the dynamic boolean flag |
| pkg/virtualization/core/storage/service/ImageManagementService_test.go | Extended test to capture and verify the new dynamic flag return value |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pkg/virtualization/core/storage/disk/virtualharddisksettingdata.go
Outdated
Show resolved
Hide resolved
pkg/virtualization/core/storage/disk/virtualharddisksettingdata.go
Outdated
Show resolved
Hide resolved
yujiaucr
reviewed
Dec 9, 2025
yujiaucr
previously approved these changes
Dec 9, 2025
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yujiaucr
reviewed
Dec 11, 2025
pkg/virtualization/core/storage/disk/virtualharddisksettingdata.go
Outdated
Show resolved
Hide resolved
yujiaucr
reviewed
Dec 11, 2025
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dhavalpopat
approved these changes
Dec 11, 2025
yujiaucr
approved these changes
Dec 12, 2025
neerajdixit-msft2
pushed a commit
that referenced
this pull request
Dec 12, 2025
Fixes for VM reconnect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following bugs:
Testing