Fix cURL linking issue in Mac installer from tag-to-release build #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix cURL linking issue
derrickstolee
approved these changes
Aug 17, 2021
derrickstolee
left a comment
There was a problem hiding this comment.
Thank you for the quick reaction! This stuff is complicated sometimes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CURL_LDFLAGSwas previously hardcoded to the incorrect value (-lcurl), now pointing to thebrew-installedlibcurl. Link to new artifacts generated by Mac build: https://github.com/vdye/git/actions/runs/1140341230Previous version of this pull request (#408) was auto-closed due to target disappearing - use this instead!