Fix installer builds #442
Merged
Fix installer builds #442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdye
approved these changes
Oct 11, 2021
vdye
left a comment
There was a problem hiding this comment.
Looks good! Just had one question about using your build-extra fork.
.github: use partial clone for build-extra Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
…workflow .github: fix errant 'filename' variable At this point in the script, 'filename' contains a relative path to a file, but that does not resolve correctly. Remove the variable and place the filename directly within the path. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
.github: fix macOS installer build Update the macOS version strings to versions that reflect the build machines and allow us to compile the release builds including FS Monitor. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
5ca6516 to
bb4e5de
Compare
ldennington
approved these changes
Oct 11, 2021
ldennington
left a comment
There was a problem hiding this comment.
Looks good - thanks for the fixes!
dscho
reviewed
Oct 13, 2021
| sed -i -e '/^# when confirmation to do so is given./a\ | ||
| use_recently_seen=no' \ | ||
| $b/git-extra/git-update-git-for-windows |
Member
There was a problem hiding this comment.
This should target /mingw64/bin/git-update-git-for-windows, correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working last week to update the
git-update-git-for-windowsscript to repeat daily reminders to upgrade. I did not succeed in doing that, but I found some other issues that are resolved in this PR:git-for-windows/build-extrarepo.filenamevariable that doesn't work in one place. Use the literal path instead.derrickstolee/git_osx_installer, too.These changes were integrated in a successful run of the
build-git-installersworkflow.