.github: replace recently seen logic #445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dscho
reviewed
Oct 13, 2021
| sed -i -e '/^# when confirmation to do so is given./a\ | ||
| use_recently_seen=no' \ | ||
| $b/git-extra/git-update-git-for-windows | ||
| sed -i -e '6 a use_recently_seen=no' \ |
Member
There was a problem hiding this comment.
I would prefer the form that does not expect line number 6 to be the one, but that matches the line after which we want to append.
Author
There was a problem hiding this comment.
The good news is that this area of the file is all comments, so inserting to a specific line is more stable than matching the text of a comment, hence the choice I made here.
dscho
approved these changes
Oct 14, 2021
Member
dscho
left a comment
There was a problem hiding this comment.
It's probably good enough for the time being.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was failing to make this work because I as modifying the wrong version of the
git-update-git-for-windowsfile.I'm still struggling to show that this works when run from the task scheduler (after installing a lower version and replacing the script in one place), but it works when I manually run the script that is generated by this installer.