Skip to content
This repository was archived by the owner on Jun 6, 2024. It is now read-only.

Add offline apt package cache in kube runtime #4226

Merged
hzy46 merged 11 commits into from
Feb 25, 2020
Merged

Add offline apt package cache in kube runtime #4226

hzy46 merged 11 commits into from
Feb 25, 2020

Conversation

@hzy46
Copy link
Contributor

@hzy46 hzy46 commented Feb 20, 2020 •
edited
Loading

This was referenced Feb 20, 2020
Closed
Closed
Binyang2014
Binyang2014 reviewed Feb 21, 2020
View reviewed changes
Binyang2014
Binyang2014 reviewed Feb 21, 2020
View reviewed changes
abuccts
abuccts reviewed Feb 21, 2020
View reviewed changes
Binyang2014
Binyang2014 approved these changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@Binyang2014 Binyang2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently it looks good to me.

For a long term, I think this feature maybe used by plugin developer and cluster admin
For plugin developer, it's better to describe its' desired packages under the plugin folder.
For cluster admin he/she only need to declare some packages need to be cached and it can be made as runtime build config

@hzy46 hzy46 merged commit c4b7e87 into master Feb 25, 2020
@hzy46
Copy link
Contributor Author

hzy46 commented Apr 20, 2020

Test cases:

  1. submit a job using ubuntu:16.04; enable ssh and a storage for it; make sure SSH and storage is usable; make sure there is no apt-get command in generated logs

  2. submit a job using ubuntu:15.10; enable ssh and a storage for it; make sure SSH and storage is usable; In this case, package cache should fall back to apt-get

@hzy46 hzy46 mentioned this pull request Apr 20, 2020
Closed
36 tasks
@Binyang2014
Copy link
Contributor

Binyang2014 commented Apr 22, 2020

Test cases:

  1. submit a job using ubuntu:16.04; enable ssh and a storage for it; make sure SSH and storage is usable; make sure there is no apt-get command in generated logs
  2. submit a job using ubuntu:15.10; enable ssh and a storage for it; make sure SSH and storage is usable; In this case, package cache should fall back to apt-get

Test finished

@debuggy debuggy mentioned this pull request Apr 23, 2020
Closed
11 tasks
@hzy46 hzy46 mentioned this pull request Apr 27, 2020
Merged
@hzy46 hzy46 deleted the zhiyuhe/package_cache branch May 11, 2020 09:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mydmdm mydmdm Awaiting requested review from mydmdm

3 more reviewers

@fanyangCS fanyangCS fanyangCS left review comments

@abuccts abuccts abuccts left review comments

@Binyang2014 Binyang2014 Binyang2014 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add offline apt package cache in kube runtime

6 participants

@hzy46 @Binyang2014 @fanyangCS @mydmdm @abuccts