Expose & override the SMTP envelope#477
Merged
Merged
Conversation
jeremy
added a commit
to basecamp/mail_view
that referenced
this pull request
Dec 11, 2012
This was referenced Jan 19, 2013
This was referenced Jan 26, 2013
…verridden. Envelope From address defaults to return_path || sender || from_addrs.first. Envelope To address defaults to destinations (to + cc + bcc). Updates all delivery methods to rely on the SMTP envelope. References mikel#421 and rails/rails#5985
|
This works great, thanks! +1 for pulling this into master |
Owner
|
Looks good, thanks Jeremy, merged. |
thegcat
pushed a commit
to planio-gmbh/mail
that referenced
this pull request
Jan 26, 2018
Mail 2.6.6 Security: * mikel#1097 – SMTP security: prevent command injection via To/From addresses. (jeremy) Bugs: * mikel#689 - Fix Exim delivery method broken by mikel#477 in 2.5.4. (jethrogb)
This was referenced Mar 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The envelope From address defaults to
return_path || sender || from_addrs.first.The envelope To address defaults to
destinations(to + cc + bcc).Set them yourself using
smtp_envelope_fromandsmtp_envelope_to.The sendmail, smtp, and smtp_connection delivery methods no longer worry about return_path vs sender vs from; they just use the
message.smtp_envelope_fromaddress.References #421 and rails/rails#5985