Fixing exception on poorly encoded subject header#558
Closed
boesemar wants to merge 6 commits into
Closed
Conversation
added 2 commits
June 8, 2013 15:15
Contributor
|
@boesemar Could you please add some tests for this. |
Author
|
Done... also fixed same issue for ruby 1.8 |
Contributor
|
Actually I had to do the following fix to get around #544 : https://github.com/gauteh/mail/tree/fallback-to-utf-16 . This removes a whitespace from your patch as well. Also, got another conversion error in decode body in message where I use the same approach to get around it. |
added 3 commits
June 30, 2013 14:41
…aracters for destination encoding in subject.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the unknown encoding crash as described:
#544