Allow for combination of non-ascii and quotes#923
Closed
averell23 wants to merge 2 commits into
Closed
Conversation
See the spec for the original problem. Basically, Encodings.encode_non_usascii(address, charset) got lost if the address did include double quotes that were escaped like this: \" and broke the address up incorrectly. This seems to fix the immediate problem, although I guess there may be more complications to this.
Contributor
Author
|
To add a bit more background: This is derived of an actual example from our production system. It might not be the most elegant solution, and I didn't re-read RFC822 on how the quote-escaping should be handled. However a test mail did send correctly with the examples given. |
This makes the whole replacement process much more ugly, but compatible with 1.8... Oh, and I'm fully aware that it is an ugly regexp with $-vars and string interpolation. D'oh.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the spec for the original problem. Basically,
Encodings.encode_non_usascii(address, charset) got lost if the
address did include double quotes that were escaped like this:
\"and broke the address up incorrectly.This seems to fix the immediate problem, although I guess there
may be more complications to this.