Implement Floor & Ceiling methods, improve code clarity & improve comments. #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Floor method to find the largest key less than or equal to a given key
- Add Ceiling method to find the smallest key greater than or equal to a given key
- Implement both methods in the base BST class so they are inherited by RBTree
- Add comprehensive test cases for both methods
- Add examples demonstrating how to use these methods
- Update RBTree documentation to list the new methods as safe inherited methods
it is expected that the Go compiler will inline this function.
|
| Branch | implement_floor_ceiling |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|
| BenchmarkTree_Insert-4 | 📈 view plot 🚷 view threshold | 303.90 ns(+10.33%)Baseline: 275.44 ns | 312.45 ns (97.26%) |
| BenchmarkTree_SearchDelete-4 | 📈 view plot 🚷 view threshold | 171.70 ns(+30.87%)Baseline: 131.20 ns | 183.18 ns (93.73%) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4 +/- ##
==========================================
+ Coverage 94.64% 99.58% +4.93%
==========================================
Files 3 3
Lines 654 715 +61
==========================================
+ Hits 619 712 +93
+ Misses 31 2 -29
+ Partials 4 1 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.