perf(core): improve support for large collections #3573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `Collection.add/remove` were defined with a spread parameter, which could result in perf degradation in very large collections. This change makes the first parameter accept also an array of items, skipping unnecessary copying of arrays when hydarting the collection. This is slightly breaking on type level, as it is no longer possible to do `coll.add(...items)` with a generic array - it only works with a tuple. The solution is to do `coll.add(items)` instead, which will type check and is also more performant (no array copies). Closes #3572
Codecov ReportBase: 99.87% // Head: 99.84% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3573 +/- ##
==========================================
- Coverage 99.87% 99.84% -0.04%
==========================================
Files 211 211
Lines 13131 13147 +16
Branches 3049 3051 +2
==========================================
+ Hits 13115 13127 +12
- Misses 16 20 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
fc33dc5 to
6a792bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
Collection.add/removewere defined with a spread parameter, which could result in perf degradation in very large collections. This change makes the first parameter accept also an array of items, skipping unnecessary copying of arrays when hydarting the collection.This is slightly breaking on type level, as it is no longer possible to do
coll.add(...items)with a generic array - it only works with a tuple. The solution is to docoll.add(items)instead, which will type check and is also more performant (no array copies).Closes #3572