fix: move checks for automated test mode into global.rs#2956
Merged
Conversation
Member
|
I think I created a conflict here touching some adjacent code... |
antiochp
approved these changes
Jul 23, 2019
Member
antiochp
left a comment
There was a problem hiding this comment.
👍 after conflicts are fixed.
Author
|
Thanks for review. I fixed the conflicts. Also had to change block time on your new chain_test_helper to 60 from 160, hope that's ok. |
Member
|
We just merged |
Member
|
Getting a windows specific test failure on CI (not sure if related, seems unlikely?) |
Member
|
Seems like a random failure. Relaunched. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved some CI checks from pipe.rs to global. I think it makes sense to do this configuration in one place and it looks like the majority of it is done there now. The only real change to the automated tests here is that the genesis block timestamp is 60 minutes in the past rather than the time now.