Skip to content

cleanup deprecation warnings about missing dyn with trait objects#2997

Merged
antiochp merged 1 commit into
mimblewimble:masterfrom
antiochp:cleanup_deprecation_warnings
Aug 26, 2019
Merged

cleanup deprecation warnings about missing dyn with trait objects#2997
antiochp merged 1 commit into
mimblewimble:masterfrom
antiochp:cleanup_deprecation_warnings

Conversation

@antiochp
Copy link
Copy Markdown
Member

@antiochp antiochp commented Aug 23, 2019

This PR fixes various deprecation warnings with rust 1.37.0, specifically around trait objects and no explicit dyn -

rustc --version
rustc 1.37.0 (eae3437df 2019-08-13)

   Compiling grin_servers v2.0.1-beta.1 (/antiochp/grin/servers)
warning: trait objects without an explicit `dyn` are deprecated
   --> servers/src/grin/dandelion_monitor.rs:105:16
    |
105 |     adapter: &Arc<DandelionAdapter>,
    |                   ^^^^^^^^^^^^^^^^ help: use `dyn`: `dyn DandelionAdapter`
    |
    = note: #[warn(bare_trait_objects)] on by default

@antiochp antiochp added the task label Aug 23, 2019
quentinlesceller
quentinlesceller approved these changes Aug 26, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@quentinlesceller quentinlesceller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@antiochp antiochp merged commit dcd405e into mimblewimble:master Aug 26, 2019
@antiochp antiochp deleted the cleanup_deprecation_warnings branch August 26, 2019 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@quentinlesceller quentinlesceller quentinlesceller approved these changes

Assignees

No one assigned

Labels

task

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@antiochp @quentinlesceller