DB v1->v2 migration#3044
Merged
Merged
Conversation
b56c08d to
08b4ce5
Compare
08b4ce5 to
31ea040
Compare
Member
Author
|
@DavidBurkett You suggested storing the db version somewhere so we easily know which version a particular node is using for its db. I played around with doing this but decided this was not necessary right now. It may be something we want to introduce at a later date once versioning gets more complex (right now its just blocks and a simple old Currently the rules are simply -
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3043.
On startup reads all the full blocks from the local db and writes them back into the db using protocol v2.
We take advantage of the blocks iterator and simply attempt to read them in v1.
Subsequent reads will fail quickly (v2 reader will not successfully read v1 data) causing the iterator to terminate early so can be safely run multiple times.
Note: This PR is overly noisy right now as it is based on the branch for #3034.Once #3034 is merged this PR will be rebased against master and should look a lot cleaner.