drop msg if sync_sender buffer is full (do not close peer connection)#3164
Merged
Conversation
hashmap
approved these changes
Dec 10, 2019
d439ee3 to
386bd02
Compare
386bd02 to
a6b8edc
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3162.
We do not necessarily want to treat a "sending on a full channel" as an error serious enough to warrant closing the peer connection.
There are various scenarios where the
sync_senderbuffer can fill up with "yet to be sent" msgs. One example is during a long running txhashset download.This PR splits out the error handling during
try_send. ADisconnectedwill propagate up and cause the caller to close the peer connection. AFullwill simply cause us to drop the msg and continue.The assumption here is that if the buffer filling up is a symptom of a more serious issue with the peer connection this will be handled at the peer level, closing the connection as necessary. It is not the responsibility of the msg queue to identify and handle this.