Skip to content

Fix compiler warning 'unnecessary parentheses around type'#3175

Merged
antiochp merged 1 commit into
mimblewimble:masterfrom
quentinlesceller:warning
Jan 6, 2020
Merged

Fix compiler warning 'unnecessary parentheses around type'#3175
antiochp merged 1 commit into
mimblewimble:masterfrom
quentinlesceller:warning

Conversation

@quentinlesceller
Copy link
Copy Markdown
Member

@quentinlesceller quentinlesceller commented Dec 20, 2019

Probably related to Rust 1.40.0.
Remove unnecessary parentheses such as:

warning: unnecessary parentheses around type
   --> store/src/pmmr.rs:113:41
    |
113 |     fn get_hash(&self, pos: u64) -> Option<(Hash)> {
    |                                            ^^^^^^ help: remove these parentheses
    |
    = note: `#[warn(unused_parens)]` on by default

@notjustanyusername
Copy link
Copy Markdown

notjustanyusername commented Jan 4, 2020

I think it's this change rust-lang/rust#64169

antiochp
antiochp approved these changes Jan 6, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@antiochp antiochp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@antiochp antiochp merged commit d31427f into mimblewimble:master Jan 6, 2020
@quentinlesceller quentinlesceller deleted the warning branch February 14, 2020 14:44
@antiochp antiochp mentioned this pull request Feb 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antiochp antiochp antiochp approved these changes

+1 more reviewer

@notjustanyusername notjustanyusername notjustanyusername approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

task

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@quentinlesceller @notjustanyusername @antiochp