no need to rehash with index to compare output with input spending it#3260
Merged
Conversation
Member
Author
|
Related - #3256 (touches the same code). We also do a |
jaspervdm
reviewed
Mar 3, 2020
Contributor
jaspervdm
left a comment
There was a problem hiding this comment.
LGTM, one small comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When validating an input (that it spends an unspent output) we do not need to re-hash the features+commit and compare against the hash in the output MMR.
We can simply compare the OutputIdentifier (features+commit) directly.
Comparing 32 bytes of a commitment will be cheaper than hashing the commitment and then comparing 32 bytes of the resulting hash.
Reading the commitment from the data file will be no more expensive than reading the hash from the hash file.
Implement
From<Input> for OutputIdentifierto keep the code clean here.TODO -
is_unspent()