[Docs] Revision to intro page#3281
Conversation
| the number. We won't elaborate on the range proof, but you just need to know | ||
| that for any `r*G + v*H` we can build a proof that will show that _v_ is greater than | ||
| that for any `r*G + v*H` we can build a proof that shows that _v_ is greater than | ||
| zero and does not overflow. |
There was a problem hiding this comment.
I thought I remembered this being in the docs somewhere.
The rangeproof shows the value is >=0 and we do technically allow 0 value commitments.
There was a problem hiding this comment.
I missed this subtlety. It is indeed mentioned in the intro, but somewhere else. I checked and couldn't find this mistake somewhere else.
| * An transaction fee in cleartext. | ||
| * A signature whose private key is computed by taking the excess value (the sum of all | ||
| * A transaction fee in cleartext. | ||
| * A signature its private key is formed by computing the excess value (the sum of all |
There was a problem hiding this comment.
Still reads a little awkward.
Maybe -
"A signature with private key computed from..."
There was a problem hiding this comment.
I tried again. The thing is that signature has no private key, so "with"/"its" is inaccurate.
Perhaps having here the details about the excess value doesn't really help.
antiochp
left a comment
There was a problem hiding this comment.
Thanks for this! This I think is a solid improvement.
A couple of typos and a couple of suggestions to revert some minor changes.
Overall 👍 but I'd like another pair of eyes on this before we merge.
|
"The public key r*G obtained from the summation of all inputs and outputs." would be better rephrased along the lines of "The public key (x-o)*G obtained from the excess x between inputs and outputs blinding factors, adjusted by kernel offset o." |
|
This introduction doesn't explain why we need "A single kernel offset to cover the full block". |
|
yes, a block has a validation step sum outputs - sum inputs = sum kernels + offset*G + 60*H |
| extremely large number). Somewhere on the blockchain, the following output appears and | ||
| should only be spendable by you: | ||
|
|
||
| X = 28*G + 3*H |
There was a problem hiding this comment.
Again, need to escape markdown syntax with *
Closes #3280.
Tried to focus on making the revision correct while keeping it clear, without delving into technical explanations (which can be found in the issue above).