[Docs] Rangeproof output documentation#3234
Merged
jaspervdm merged 2 commits intoFeb 25, 2020
Merged
Conversation
jaspervdm
reviewed
Feb 25, 2020
Contributor
jaspervdm
left a comment
There was a problem hiding this comment.
Thanks for PRing this in! I haven't verified the exact values you used, but overall the explanation seems good. Just have a small comment
|
|
||
| `ed9e1ee8cb2db1e71311cacd9e1d0b6dbf6cfab15723ec3cac4cc52154fc9d53 (107477520278964342277912932357487306000871347661927764278313323679782451060051)` b2 | ||
|
|
||
| And last we have the commitments Li and Ri of every round. In Grin we have 64-bit range proofs. This means we have six rounds (log(64) = 6); however, since we stop early, we only do five rounds, so 10 points instead of 12. The implementation always computes L before R. (*inner_product_impl.h 627*) |
Contributor
There was a problem hiding this comment.
In Grin we have 64-bit range proofs
Could be interpreted to mean range proofs are 64 bits long. Could you rephrase to something like
Range proofs in Grin prove the value is within 64 bits
Contributor
|
Thanks! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: PR Rangeproof documentation
about: Bulletproofs output bytes
title: '[Docs] Rangeproof output documentation'
labels: ''
assignees: ''
This PR adds an additional documentation document, explaining how to recover the parameters of a range proof used in Grin output, from the byte output. This document was added and also linked to in the table of contents.