sync_all() on leaf_set and prune_list#3354
Merged
Merged
Conversation
quentinlesceller
approved these changes
Aug 17, 2020
Member
quentinlesceller
left a comment
There was a problem hiding this comment.
👍 makes sense didn't know about all that fsync stuff. Good to know. LGTM
Member
Author
|
@quentinlesceller thanks for taking a look. I have not touched this branch for a bit so I'm going to pick it up again and do some more testing before merging. |
3d0dd1b to
f71389d
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
4.0.0 has a dedicated branch now. Opening this up against master.
We should call
sync_all()(akafsync) when writing the leaf_set (and prune_list) withsave_via_temp_file.Renaming a file without first calling
fsyncis not safe.See https://stackoverflow.com/questions/7433057/is-rename-without-fsync-safe
Also avoid removing the original file before renaming the temp file as this kind of defeats the atomicity of the "temp file and rename" approach.
Related #3352 (fsync rabbit hole).