Skip to content

maintain preferred peer connections#3435

Merged
antiochp merged 1 commit into
mimblewimble:masterfrom
antiochp:maintain_preferred_peers
Sep 8, 2020
Merged

maintain preferred peer connections#3435
antiochp merged 1 commit into
mimblewimble:masterfrom
antiochp:maintain_preferred_peers

Conversation

@antiochp
Copy link
Copy Markdown
Member

@antiochp antiochp commented Sep 7, 2020

  • If we specify preferred_peers in config then attempt to maintain these when cleaning excess peers.
  • Pass preferred_peers into clean_peers() to facilitate this.
  • General cleanup passing a slice of PeerAddr around rather than Option<Vec<PeerAddr>>.

Tested on mainnet and "preferred peers" works a lot more robustly now...

quentinlesceller
quentinlesceller approved these changes Sep 7, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@quentinlesceller quentinlesceller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looking good

@antiochp antiochp merged commit 655e080 into mimblewimble:master Sep 8, 2020
@antiochp antiochp deleted the maintain_preferred_peers branch September 8, 2020 07:22
@antiochp antiochp mentioned this pull request Sep 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@quentinlesceller quentinlesceller quentinlesceller approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@antiochp @quentinlesceller