Fix leading zeroes bugs#3763
Merged
Merged
Conversation
Contributor
|
Thank you very much, now it's syncing without problems at arm-v7a arch. |
yeastplume
reviewed
Jul 20, 2023
Member
|
I don't have a 32 bit install of anything to test against, but it looks straightforward and if @ardocrat has tested it looks good to me 👍. It feels like trying to bit shift against a usize should trigger some kind of Rust warning, it's an easy thing to overlook. |
bayk
added a commit
to mwcproject/mwc-node
that referenced
this pull request
Jun 23, 2024
* remove two unneeded mut's * ensure correct size for leading_zeros()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3762 in suggested way.
No consensus change; makes PoW verification work correctly on select 32-bit platforms.
No new functionality / unit tests.
No impact beyond 32-bit platform bugfix.
Tested with cargo test -all and mainnet sync catching up a few weeks.
No change to documentation.