Skip to content

Update croaring to 0.5.2#3770

Merged
yeastplume merged 1 commit into
mimblewimble:masterfrom
ardocrat:croaring_build_fix
Sep 28, 2023
Merged

Update croaring to 0.5.2#3770
yeastplume merged 1 commit into
mimblewimble:masterfrom
ardocrat:croaring_build_fix

Conversation

@ardocrat

Copy link
Copy Markdown
Contributor

Previous croaring crate version 0.4.6 uses bindgen crate version 0.56.0 that leads to build errors, such as: rust-lang/rust-bindgen#2500 and rust-lang/rust-bindgen#2312 on recent C compilers (e.g. GCC 13.2.1 under Arch Linux), more recent croaring crate version 0.5.2 uses bindgen crate version 0.59.0 and has no such issue (tested under Arch Linux with GCC 13.2.1 and glibc 2.38).

@yeastplume

Copy link
Copy Markdown
Member

Yep, getting all sorts of errors on grin wallet tests. Looks good, thanks for looking into the cause.

@yeastplume yeastplume merged commit 059ae03 into mimblewimble:master Sep 28, 2023
@ardocrat ardocrat deleted the croaring_build_fix branch February 2, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants