Rust 1.80+ fixes & accumulated warning cleanup #3796
Conversation
chain/tests/chain_test_helper.rs
Outdated
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| #![allow(dead_code)] |
There was a problem hiding this comment.
there's some cargo oddness that's causing a 'not used' warning for the clean_output_dir function below during compilation, even though it's configured as test only. I spent some time trying to track it down and couldn't find a reason for it. I could possibly spend more time on it
There was a problem hiding this comment.
Maybe ask around on IRC #rust or other rust forums if other people have run into that issue. I see that googling for
rust 'not used' warning for test code
also brings up discussions on stack overflow, reddit, and the Rust programming language forum...
tromp
left a comment
There was a problem hiding this comment.
Looks fine to me. Just would prefer not to see ignore dead code directive...
Just moved the directive to be function-scope rather than module scope, which it should have been in the first place. |
* Update grin_secp to 0.7.14 (#3788) * Update versioning on master to 5.4.0-alpha.0 * Update versioning on master to 5.4.0-alpha.0 (#3789) * Remove Merkle Proof Generation from Foreign API `get_outputs` (#3792) * Update versioning on master to 5.4.0-alpha.0 * Remove merkle proof generation from foreign API * Rust 1.80+ fixes & accumulated warning cleanup (#3796) * Update versioning on master to 5.4.0-alpha.0 * updates for 1.80 and other accumulated warnings * further warning cleanups * move dead code tag to function defn rather than module * Chain type field (#3790) * Adding chain type field into get_status rpc * formatting * update version for next build --------- Co-authored-by: aglkm <39521015+aglkm@users.noreply.github.com>
Fix for current build issues on rust 1.8+, as well as fixes for all warnings and future deprecation warnings. Touches core code (though not in any complex way) so needs another level of review.
timedeps) to 0.21edge_bitsfield inCuckooParamsstructRPCErrorNaiveDateTime::from_timestamp_optreplaced withDateTime::from_timestamp ... .naive_utc()NaiveDateTime::timestamp()replaced with.and_utc().timestamp()timestamp_nanos()->timestamp_nanos_opt()clean_output_dir()inchain/tests/commonmade conditional on test envbuiltcrate (build-only dependency) to 0.7build.rsaccording tobuiltcrate updateslog4rscrate to 1.3, modifyutil::loggeraccordinglyanyhowcrate toutilto satisfy log4rs update dependencychain_test_helpertest (incorrect unused code warning reported otherwise).cargo/config->.cargo/config.toml